Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device automation support to binary_sensor entities #26643

Merged

Conversation

@emontnemery
Copy link
Contributor

commented Sep 14, 2019

Description:

Add device automation conditions and triggers to binary_sensor entities.

This PR is intended as a step towards home-assistant/architecture#178

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 14, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

This looks great !

emontnemery added 3 commits Sep 17, 2019
@emontnemery emontnemery force-pushed the emontnemery:device_automation_binary_sensor branch from 851c1d5 to 685d555 Sep 17, 2019
@emontnemery emontnemery changed the title WIP: Add device automation support to binary_sensor entities Add device automation support to binary_sensor entities Sep 17, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 17, 2019
emontnemery added 2 commits Sep 22, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 22, 2019
@balloob balloob merged commit e5f6f33 into home-assistant:dev Sep 22, 2019
11 checks passed
11 checks passed
CI Build #20190922.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94.07% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 22, 2019
@lock lock bot locked and limited conversation to collaborators Sep 23, 2019
@emontnemery emontnemery deleted the emontnemery:device_automation_binary_sensor branch Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.