Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Environment Canada weather forecast, retain icon_code sensor #26646

merged 2 commits into from Sep 15, 2019


Copy link

commented Sep 14, 2019


  • Bumps env_canada to 0.0.25 to address issue of weather forecasts not updating
  • Retains icon_code sensor for use with TileBoard

Pull request with documentation for (if applicable): home-assistant/


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2019
@michaeldavie michaeldavie referenced this pull request Sep 14, 2019
2 of 2 tasks complete
@MartinHjelmare MartinHjelmare changed the title Environment Canada - Fix weather forecast, retain icon_code sensor Fix Environment Canada weather forecast, retain icon_code sensor Sep 14, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 14, 2019
@MartinHjelmare MartinHjelmare merged commit fd359c6 into home-assistant:dev Sep 15, 2019
12 checks passed
12 checks passed
CI Build #20190914.56 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5885c3f...0666a65
codecov/project 93.98% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 15, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 15, 2019
* dev: (38 commits)
  Fix Environment Canada weather forecast, retain icon_code sensor (home-assistant#26646)
  Rename MockToggleDevice to MockToggleEntity (home-assistant#26644)
  Refactor nzbget to support future platform changes (home-assistant#26462)
  deCONZ - Remove mechanisms to import a configuration from configuration.yaml (home-assistant#26648)
  deCONZ - battery sensor instead of battery attribute (home-assistant#26591)
  Add built in weather to Homematic IP Cloud (home-assistant#26642)
  Move deCONZ services to their own file (home-assistant#26645)
  Add group attribute to Homematic IP Cloud (home-assistant#26618)
  Add iaqualink binary sensor and unique_id (home-assistant#26616)
  zha ZCL color loop effect (home-assistant#26549)
  [ci skip] Translation update
  deCONZ -  create deconz_events through sensor platform (home-assistant#26592)
  Update azure-pipelines-wheels.yml for Azure Pipelines
  Update azure-pipelines-wheels.yml
  Refactor Bluetooth Tracker to async (home-assistant#26614)
  Fix Typo (home-assistant#26612)
  [ci skip] Translation update
  Disable Watson TTS Telemetry (home-assistant#26253)
  Improve bluetooth tracker device code (home-assistant#26067)
  Bump zigpy-zigate to 0.3.1 (home-assistant#26600)
@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.