Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - Remove mechanisms to import a configuration from configuration.yaml #26648

Merged

Conversation

@Kane610
Copy link
Member

commented Sep 14, 2019

Breaking Change:

With Home Assistant releases 0.100 and 0.101 deCONZ will end support of importing configurations from configuration.yaml

In 0.100, deCONZ will ignore what is in the deconz:
In 0.101, deCONZ will fail on config validation and not allow the deconz section to exist in configuration.yaml.

TL;DR This will no longer work:

deconz:

Description:

Remove import mechanism of configuration.yaml, but allow deconz: to exist

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@Kane610 Kane610 self-assigned this Sep 14, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2019
@Kane610 Kane610 merged commit 9c2053a into home-assistant:dev Sep 14, 2019
10 checks passed
10 checks passed
CI Build #20190914.62 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Sep 14, 2019
@Kane610 Kane610 deleted the Kane610:deconz-remove-configuration_yaml-support branch Sep 14, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Removing support for config yaml goes against what home assistant is saying to users.

Config yaml is not going away.

I think this should be discussed further. CC @balloob

@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

This is the same thing as the unifi component we discussed a few days ago @MartinHjelmare. Of course config yaml isn't going away. But it is up to each integration how it is configured.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

I don't think it can be up to each integration since home assistant is saying config yaml won't go away. Those two ways are not compatible.

I think we should write an ADR and make it clear what the requirements are for config ways when structuring integrations.

My suggestion is that we require both config yaml and config flow for new integrations. And we don't allow removing either config yaml or config flow as a way of config for existing integrations.

Whatever the outcome is, I hope we make it more clear than today what the expectations for integrations are for users, for contributors and for organization members.

@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

There are multiple integrations that only allow configuration through gui; met, ps4, SMHI (axis, deconz and unifi soon as well)

Nothing wrong with clearer guidelines but allowing integrations not having a configuration.yaml path is not the same as saying that configuration.yaml is going away

For me personally I only want to support one path, the path that easily can be modified when new features arrive. Supporting configuration.yaml is far too static and limits evolution

KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 15, 2019
* dev: (38 commits)
  Fix Environment Canada weather forecast, retain icon_code sensor (home-assistant#26646)
  Rename MockToggleDevice to MockToggleEntity (home-assistant#26644)
  Refactor nzbget to support future platform changes (home-assistant#26462)
  deCONZ - Remove mechanisms to import a configuration from configuration.yaml (home-assistant#26648)
  deCONZ - battery sensor instead of battery attribute (home-assistant#26591)
  Add built in weather to Homematic IP Cloud (home-assistant#26642)
  Move deCONZ services to their own file (home-assistant#26645)
  Add group attribute to Homematic IP Cloud (home-assistant#26618)
  Add iaqualink binary sensor and unique_id (home-assistant#26616)
  zha ZCL color loop effect (home-assistant#26549)
  [ci skip] Translation update
  deCONZ -  create deconz_events through sensor platform (home-assistant#26592)
  Update azure-pipelines-wheels.yml for Azure Pipelines
  Update azure-pipelines-wheels.yml
  Refactor Bluetooth Tracker to async (home-assistant#26614)
  Fix Typo (home-assistant#26612)
  [ci skip] Translation update
  Disable Watson TTS Telemetry (home-assistant#26253)
  Improve bluetooth tracker device code (home-assistant#26067)
  Bump zigpy-zigate to 0.3.1 (home-assistant#26600)
  ...
@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

I forgot to mention that I removed any references to configuration.yaml in deCONZ integration documentation nearly a year ago.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.