Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "PTZ is not available on this camera" warning #26649

Merged
merged 2 commits into from Sep 18, 2019

Conversation

@definitio
Copy link
Contributor

commented Sep 14, 2019

Description:

Home Assistant prints "PTZ is not available on this camera" warning on every start because my camera doesn't support PTZ. It's really annoying. I think that message should has 'info' severity because there is no problem.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
Copy link
Member

left a comment

ok to merge when changed to debug.

@@ -282,7 +282,7 @@ def setup_ptz(self):
"""Set up PTZ if available."""
_LOGGER.debug("Setting up the ONVIF PTZ service")
if self._camera.get_service("ptz", create=False) is None:
_LOGGER.warning("PTZ is not available on this camera")
_LOGGER.info("PTZ is not available on this camera")

This comment has been minimized.

Copy link
@balloob

balloob Sep 17, 2019

Member

Let's make it debug. Also, "this" is useless in case you have 2 cameras.

This comment has been minimized.

Copy link
@definitio

definitio Sep 18, 2019

Author Contributor

Done

Dev automation moved this from Needs review to Reviewer approved Sep 17, 2019
@balloob balloob merged commit 9cd5c54 into home-assistant:dev Sep 18, 2019
9 checks passed
9 checks passed
CI Build #20190918.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 18, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.