Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "PTZ is not available on this camera" warning #26649

Merged
merged 2 commits into from Sep 18, 2019

Conversation

definitio
Copy link
Contributor

@definitio definitio commented Sep 14, 2019

Description:

Home Assistant prints "PTZ is not available on this camera" warning on every start because my camera doesn't support PTZ. It's really annoying. I think that message should has 'info' severity because there is no problem.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@probot-home-assistant probot-home-assistant bot added integration: onvif small-pr PRs with less than 30 lines. labels Sep 14, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 14, 2019
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge when changed to debug.

@@ -282,7 +282,7 @@ def setup_ptz(self):
"""Set up PTZ if available."""
_LOGGER.debug("Setting up the ONVIF PTZ service")
if self._camera.get_service("ptz", create=False) is None:
_LOGGER.warning("PTZ is not available on this camera")
_LOGGER.info("PTZ is not available on this camera")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it debug. Also, "this" is useless in case you have 2 cameras.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Dev automation moved this from Needs review to Reviewer approved Sep 17, 2019
@balloob balloob merged commit 9cd5c54 into home-assistant:dev Sep 18, 2019
Dev automation moved this from Reviewer approved to Done Sep 18, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants