Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zha ignoring 0 second light transitions #26654

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@abmantis
Copy link
Contributor

commented Sep 15, 2019

Description:

Allow turning a light on instantly, with no transition time.
This is actually required for IKEA lights to be able to set brightness
and color temp in a single call.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
Allow turning a light on instantly, with no transition time.
This is actually required for IKEA lights to be able to set brightness
and color temp in a single call.
@abmantis abmantis requested review from Adminiuga and dmulcahey as code owners Sep 15, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
@MartinHjelmare MartinHjelmare changed the title zha: fix 0 second transitions being ignored. Fix zha ignoring 0 second light transitions Sep 15, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 16, 2019
@dmulcahey dmulcahey merged commit 8de84c5 into home-assistant:dev Sep 16, 2019
12 checks passed
12 checks passed
CI Build #20190915.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9c2053a...e26579c
Details
codecov/project 93.98% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 16, 2019
@lock lock bot locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.