Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `for` to binary_sensor, light and switch device triggers #26658

Merged

Conversation

@emontnemery
Copy link
Contributor

commented Sep 15, 2019

Description:

Add support for for to binary_sensor, light and switch device triggers.
Add WS API device_automation/trigger/capabilities

Depends on balloob/voluptuous-serialize#9

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@emontnemery emontnemery requested a review from home-assistant/core as a code owner Sep 15, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
@emontnemery emontnemery force-pushed the emontnemery:device_automation_trigger_for branch from afdbcf1 to 738d10e Sep 15, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 15, 2019
@emontnemery emontnemery changed the title WIP: Add support for `for` to switch and light device automation triggers Add support for `for` to switch and light device automation triggers Sep 17, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 17, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Sep 21, 2019

How will we deal with this in the frontend ?

@emontnemery

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

@emontnemery emontnemery force-pushed the emontnemery:device_automation_trigger_for branch from 152d87a to 376b4dd Sep 28, 2019
@emontnemery emontnemery changed the title Add support for `for` to switch and light device automation triggers Add support for `for` to binary_sensor, light and switch device triggers Sep 28, 2019
@balloob
balloob approved these changes Oct 1, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 1, 2019
emontnemery added 9 commits Sep 28, 2019
@emontnemery emontnemery force-pushed the emontnemery:device_automation_trigger_for branch from 79d70b1 to 4cec102 Oct 2, 2019
@emontnemery emontnemery merged commit 65ce3b4 into home-assistant:dev Oct 2, 2019
11 checks passed
11 checks passed
CI Build #20191002.78 had test failures
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 98.18% of diff hit (target 94.31%)
Details
codecov/project 94.32% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@emontnemery emontnemery deleted the emontnemery:device_automation_trigger_for branch Oct 3, 2019
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.