Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volumio set shuffle #26660

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@zewelor
Copy link
Contributor

commented Sep 15, 2019

Description:

Volumio expects true / false ( lowercase ). From https://volumio.github.io/docs/API/REST_API.html
"Where key is true or false; if value is absent it toggles.". Now its possible to turn on shuffle, but then volumio responds with value "True"or "False" in getState json, which is wrong and breaks reading current shuffle state.

@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 15, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Further updates, after this fix, to this integration should not be made until the device specific interface code, I/O and data parsing, has been moved to a standalone library published on pypi.

@MartinHjelmare MartinHjelmare merged commit 39edc45 into home-assistant:dev Sep 17, 2019
10 checks passed
10 checks passed
CI Build #20190915.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 17, 2019
@zewelor zewelor deleted the zewelor:fix_volumio_set_shuffle branch Sep 18, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.