Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kaiterra integration #26661

Merged
merged 9 commits into from Sep 22, 2019

Conversation

@Michsior14
Copy link
Contributor

commented Sep 15, 2019

Description:

Support for Laser Egg and Sansedge devices.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10374

Example entry for configuration.yaml (if applicable):

kaiterra:
  api_key: YOUR_API_KEY
  devices:
    - device_id: YOUR_DEVICE_ID
      type: YOUR_DEVICE_TYP

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

Hi @Michsior14,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
@Michsior14 Michsior14 referenced this pull request Sep 15, 2019
2 of 2 tasks complete
Dev automation moved this from Needs review to Review in progress Sep 15, 2019
@MartinHjelmare MartinHjelmare changed the title add Kaiterra integration Add Kaiterra integration Sep 15, 2019
@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 15, 2019
@project-bot project-bot bot moved this from Review in progress to Needs review in Dev Sep 15, 2019
Michsior14 added 5 commits Sep 21, 2019
Copy link
Member

left a comment

We mostly just need to tidy up dict access.

homeassistant/components/kaiterra/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/kaiterra/sensor.py Outdated Show resolved Hide resolved
Michsior14 and others added 2 commits Sep 21, 2019
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
Copy link
Member

left a comment

Very nice!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 21, 2019

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit fbe85a2 into home-assistant:dev Sep 22, 2019
9 checks passed
9 checks passed
CI Build #20190921.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 22, 2019
@lock lock bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.