Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automation description #26662

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@emontnemery
Copy link
Contributor

commented Sep 15, 2019

Description:

When using the automation editor, any manually added comments are wiped.
Allow adding a description string to the automation instead, with the same purpose as a comment.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@emontnemery emontnemery requested a review from home-assistant/core as a code owner Sep 15, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
@emontnemery

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

Are tests needed for this?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Probably, but wait for a core review if this feature hasn't already been discussed.

@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

I mean there is an proposal on architecture repository. I would suggest to implement this proposal.

@emontnemery

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

@pvizeli I can't find it, can you share the issue number?

@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

@emontnemery emontnemery changed the title Add support for automation annotation Add support for automation description Sep 17, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 17, 2019
@balloob balloob merged commit 10572a6 into home-assistant:dev Sep 17, 2019
9 checks passed
9 checks passed
CI Build #20190917.63 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 17, 2019
@lock lock bot locked and limited conversation to collaborators Sep 18, 2019
@emontnemery emontnemery deleted the emontnemery:automation_annotation branch Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.