Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - Improve service tests #26663

Merged
merged 5 commits into from Sep 16, 2019

Conversation

@Kane610
Copy link
Member

commented Sep 15, 2019

Description:

Reworking the service tests to properly assert wanted outcome and to improve coverage

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Kane610 Kane610 self-assigned this Sep 15, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 15, 2019
@Kane610 Kane610 marked this pull request as ready for review Sep 15, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 15, 2019
field = data.get(SERVICE_FIELD, "")
entity_id = data.get(SERVICE_ENTITY)
data = data[SERVICE_DATA]

gateway = get_master_gateway(hass)
if CONF_BRIDGEID in data:
gateway = hass.data[DOMAIN][data[CONF_BRIDGEID]]
if bridgeid:

This comment has been minimized.

Copy link
@Kane610

Kane610 Sep 16, 2019

Author Member

Make sure bridgeid exist in Hass.data as well

Dev automation moved this from Needs review to Reviewer approved Sep 16, 2019
@pvizeli pvizeli merged commit 5116d02 into home-assistant:dev Sep 16, 2019
9 checks passed
9 checks passed
CI Build #20190915.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 16, 2019
@Kane610 Kane610 deleted the Kane610:deconz-improve-tests-for-services branch Sep 16, 2019
@lock lock bot locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.