Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Envoy detection and support multiple Envoys #26665

Merged
merged 3 commits into from Sep 17, 2019

Conversation

@jesserizzo
Copy link
Contributor

commented Sep 15, 2019

Description:

Better detection of Envoy model, support for multiple Envoys

Related issue (if applicable): fixes #26124

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10378

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@jesserizzo jesserizzo force-pushed the jesserizzo:dev branch from 370e232 to d5074e1 Sep 15, 2019
Dev automation moved this from Needs review to Review in progress Sep 15, 2019
@MartinHjelmare MartinHjelmare changed the title Enphase envoy - Better detection of Envoy, support for multiple Envoys Improve Envoy detection and support multiple Envoys Sep 15, 2019
Copy link
Member

left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Sep 15, 2019
@MartinHjelmare MartinHjelmare merged commit 4060f13 into home-assistant:dev Sep 17, 2019
9 checks passed
9 checks passed
CI Build #20190915.40 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 17, 2019
@lock lock bot locked and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.