Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysensors validation for composite entities #26666

Merged

Conversation

@MartinHjelmare
Copy link
Member

commented Sep 15, 2019

Breaking Change:

Description:

  • Composite entities require multiple value types to be present in child values to function. Any of those value types should trigger an entity update if updated.
  • Always write platform v names as sets.
  • Run black.

Related issue (if applicable):
fixes #24085, fixes #24686

Pull request with documentation for home-assistant.io (if applicable):
N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
* Composite entities require multiple value types to be present in
  child values to function. Any of those value types should trigger an
  entity update if updated.
* Always write platform v names as sets.
* Run black.
@project-bot project-bot bot added this to Needs review in Dev Sep 15, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 17, 2019
@balloob balloob merged commit c17057d into home-assistant:dev Sep 17, 2019
10 checks passed
10 checks passed
CI Build #20190915.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 17, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Looks good 🐬

@MartinHjelmare MartinHjelmare deleted the MartinHjelmare:fix-mysensors-composite-validation branch Sep 17, 2019
@lock lock bot locked and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.