Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when losing nzbget connection #26667

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@chriscla
Copy link
Contributor

commented Sep 15, 2019

Description:

Fixes a crash when using the nzbget component and nzbget becomes unavailable. Crash was caused by not catching the proper exception type.

Tested this manually by stopping nzbget, ensuring no crash, re-starting nzbget and ensuring sensor monitoring worked again.

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@chriscla

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

@MartinHjelmare -- this got missed when I was merging in different branches (still a git n00b here)

Copy link
Member

left a comment

Thanks!

Dev automation moved this from Needs review to Reviewer approved Sep 16, 2019
@MartinHjelmare MartinHjelmare merged commit 719a601 into home-assistant:dev Sep 16, 2019
12 checks passed
12 checks passed
CI Build #20190915.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f45f8f2...6a6fbba
Details
codecov/project 93.99% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 16, 2019
@lock lock bot locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.