Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ rewrite sensor tests #26679

Merged
merged 5 commits into from Sep 18, 2019

Conversation

@Kane610
Copy link
Member

commented Sep 16, 2019

Description:

Improve deconz sensor tests

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Kane610 Kane610 self-assigned this Sep 16, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 16, 2019
@Kane610 Kane610 changed the title deCONZ fix sensor tests deCONZ rewrite sensor tests Sep 17, 2019
@Kane610 Kane610 changed the title deCONZ rewrite sensor tests WIP: deCONZ rewrite sensor tests Sep 18, 2019
@Kane610

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

I've identified a few things to improve before this PR is ready

Fixed!

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 18, 2019
Kane610 added 4 commits Sep 16, 2019
Fix sensor platform not loading climate devices as sensors
@Kane610 Kane610 force-pushed the Kane610:deconz-fix-sensor-tests branch from 939a706 to 20631dd Sep 18, 2019
@Kane610 Kane610 changed the title WIP: deCONZ rewrite sensor tests deCONZ rewrite sensor tests Sep 18, 2019
Dev automation moved this from Incoming to Reviewer approved Sep 18, 2019
@balloob balloob merged commit 886d8bd into home-assistant:dev Sep 18, 2019
11 checks passed
11 checks passed
CI Build #20190918.46 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.01%)
Details
codecov/project 94% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 18, 2019
@Kane610 Kane610 deleted the Kane610:deconz-fix-sensor-tests branch Sep 18, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.