Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative name for Tibber sensors #26685

Merged
merged 2 commits into from Sep 18, 2019

Conversation

@Danielhiversen
Copy link
Member

commented Sep 17, 2019

Description:

Add alternative name for Tibber sensors

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Sep 17, 2019
Dev automation moved this from Needs review to Review in progress Sep 17, 2019
homeassistant/components/tibber/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/tibber/sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from Review in progress to Reviewer approved Sep 17, 2019
Copy link
Member

left a comment

Looks great!

@Danielhiversen Danielhiversen merged commit 72baf56 into dev Sep 18, 2019
11 checks passed
11 checks passed
CI Build #20190917.66 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.01% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 18, 2019
@Danielhiversen Danielhiversen deleted the tibber branch Sep 18, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.