Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash for esphome lights #26703

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@CQoute
Copy link
Contributor

commented Sep 18, 2019

Fix for esphome lights to use the flash feature

Description:

Previously the flash function would not pass as the esp api client was expecting the attribute 'flash_length' and not 'flash'.

Checklist:

  • [ x ] The code change is tested and works locally.
  • [ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x ] There is no commented out code in this PR.
  • [ x ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Fix for esphome lights to use the flash feature
@CQoute CQoute requested a review from OttoWinter as a code owner Sep 18, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Hi @CQoute,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Sep 18, 2019
@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 18, 2019
@MartinHjelmare MartinHjelmare changed the title Update light.py Fix flash for esphome lights Sep 20, 2019
@fabaff
fabaff approved these changes Sep 21, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
@fabaff fabaff merged commit 544cdae into home-assistant:dev Sep 21, 2019
12 checks passed
12 checks passed
CI Build #20190918.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing 8a39924...c7ec7fd
Details
codecov/project 94.01% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 21, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.