Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alexa integration to use dt_util #26723

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@tsvi
Copy link
Contributor

commented Sep 19, 2019

Breaking Change:

Description:

Move Alexa to use dt_util instead of native datetime.

@MartinHjelmare The next ones I'm going one by one. I changed use of datetime.now() to utcnow() as we are formatting it for UTC (appended Z according to ISO8601 means UTC).

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
@MartinHjelmare MartinHjelmare requested a review from balloob Sep 19, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 19, 2019
@balloob balloob merged commit 1041b10 into home-assistant:dev Sep 19, 2019
8 of 12 checks passed
8 of 12 checks passed
CI (FullCheck Mypy)
Details
CI (FullCheck Pylint)
Details
CI (Tests PyTest Python36)
Details
CI (Tests PyTest Python37)
Details
CI Build #20190919.31 succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94%)
Details
codecov/project 94% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
@tsvi tsvi deleted the tsvi:alexa_dt_util branch Sep 19, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
@tsvi tsvi restored the tsvi:alexa_dt_util branch Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.