Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps aiohttp to 3.6.0 #26728

merged 1 commit into from Sep 19, 2019


Copy link

commented Sep 19, 2019


Bumps aiohttp to 3.6.0


Unit tests have been updated to be compatible with this release.

Related issue (if applicable): n/a

Pull request with documentation for (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
@frenck frenck marked this pull request as ready for review Sep 19, 2019
@frenck frenck requested a review from home-assistant/core as a code owner Sep 19, 2019

This comment has been minimized.

Copy link

commented Sep 19, 2019

Before we can merge:

  • Test Ingress
  • Test RemoteSNI SocketSite injection
  • Test application freeze on discovery
  • Test mjpeg stream
  • Test API proxy

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

  • Tested mjpeg stream, works fine.
  • All my devices on my home network are discovered in a timely fashion.
  • TTS works.
  • Tested with Nabu Casa Remote UI (including mjpeg stream).
Dev automation moved this from Needs review to Reviewer approved Sep 19, 2019
@pvizeli pvizeli merged commit a8a485a into dev Sep 19, 2019
12 checks passed
12 checks passed
CI Build #20190919.47 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 770eeaf...cd4c0c2
codecov/project 94% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0186 branch Sep 19, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.