Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Linky sensors to Linky meter device #26738

Merged
merged 2 commits into from Sep 24, 2019

Conversation

@piitaya
Copy link
Contributor

commented Sep 19, 2019

Breaking Change:

Users will need to remove and re-add the linky integration to clear the device registry.

Description:

I think it's better to group linky sensors to one unique device (to avoid setting area for all the sensor for example)

Before:
Capture d’écran 2019-09-19 à 20 44 50

After:
Capture d’écran 2019-09-19 à 20 45 04

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
@piitaya piitaya changed the title Group Linky sensors to Llnky meter device Group Linky sensors to Linky meter device Sep 19, 2019
@Quentame

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Copy link
Member

left a comment

See comment above.

Dev automation moved this from Needs review to Review in progress Sep 23, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 23, 2019
@MartinHjelmare MartinHjelmare merged commit 4408286 into home-assistant:dev Sep 24, 2019
12 checks passed
12 checks passed
CI Build #20190923.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0e201fd...87fad48
Details
codecov/project 94.1% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.