Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump restrictedpython to 5.0 #26741

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@frenck
Copy link
Member

commented Sep 19, 2019

Description:

Bump restrictedpython to 5.0
https://restrictedpython.readthedocs.io/en/latest/CHANGES.html#id1

  • Add support for f-strings in Python 3.6+
  • Revert the Allowance of the ... (Ellipsis) statement, as of 4.0. It is not needed to support Python 3.8. The security implications of the Ellipsis Statement is not 100 % clear and is not checked. ... (Ellipsis) is disallowed again.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
@frenck frenck force-pushed the frenck-2019-0188 branch from aa1ae1b to fad2084 Sep 19, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 19, 2019
@balloob balloob merged commit c8fb7ce into dev Sep 19, 2019
11 checks passed
11 checks passed
CI Build #20190919.70 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0e201fd...fad2084
Details
codecov/project 94% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0188 branch Sep 19, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 20, 2019
* dev: (167 commits)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  Add Plex config flow support (home-assistant#26548)
  Bump pyobihai to fix issue with user account (home-assistant#26736)
  Bump TRADFRI (home-assistant#26731)
  Encode prometheus metric names per the prom spec (home-assistant#26639)
  Bump aiohttp to 3.6.1 (home-assistant#26739)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.