Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up ZHA dependencies #26746

Merged

Conversation

@Adminiuga
Copy link
Contributor

commented Sep 19, 2019

Description:

Bump up zha dependencies. Syncs with Zigpy API changes

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@Adminiuga Adminiuga requested a review from dmulcahey as a code owner Sep 19, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
Copy link
Contributor

left a comment

:shipit:

Dev automation moved this from Needs review to Reviewer approved Sep 19, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

Remember to change the PR title before merging. 👍

@dmulcahey

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

handle_message (used from cluster) in the tests needs to be updated to account for zigpy API changes

@Adminiuga Adminiuga changed the title WIP Bump up ZHA dependencies Bump up ZHA dependencies Sep 21, 2019
@Adminiuga Adminiuga force-pushed the Adminiuga:ac/experimental/zigpy-reply-handling branch from 4722fd2 to 30faade Sep 21, 2019
@dmulcahey

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

@balloob any idea what's wrong here w/ code coverage? I see it...

@Adminiuga Adminiuga closed this Sep 23, 2019
Dev automation moved this from Reviewer approved to Cancelled Sep 23, 2019
@Adminiuga Adminiuga reopened this Sep 23, 2019
Dev automation moved this from Cancelled to Needs review Sep 23, 2019
Adminiuga added 3 commits Sep 10, 2019
@Adminiuga Adminiuga force-pushed the Adminiuga:ac/experimental/zigpy-reply-handling branch from 30faade to e6aa523 Sep 23, 2019
@Adminiuga Adminiuga merged commit 9c0fbfd into home-assistant:dev Sep 23, 2019
9 checks passed
9 checks passed
CI Build #20190923.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Needs review to Done Sep 23, 2019
@Adminiuga Adminiuga deleted the Adminiuga:ac/experimental/zigpy-reply-handling branch Sep 23, 2019
@lock lock bot locked and limited conversation to collaborators Sep 24, 2019
@Adminiuga

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

fixes #26281

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.