Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ebusd Vaillant "bai" sensors #26750

Merged
merged 12 commits into from Sep 27, 2019

Conversation

@sashao
Copy link
Contributor

commented Sep 19, 2019

Description:

Vaillant ecoTec plus 360 "bai" circuit supports lot more sensors than home assistant currently have.

Documentation PR: home-assistant/home-assistant.io#10398

Example entry for configuration.yaml (if applicable):

ebusd:
  host: 192.168.1.10
  circuit: 'bai'
  monitored_conditions:.
    - 'ReturnTemperature'
    - 'HotWaterTemperature'
    - 'StorageTemperature'
    - 'DesiredStorageTemperature'
    - 'OutdoorsTemperature'
    - 'WaterPreasure'
    - 'AverageIgnitionTime'
    - 'MaximumIgnitionTime'
    - 'MinimumIgnitionTime'
    - 'DesiredFlowTemperature'
    - 'CentralHeatingPump'
    - 'HeatingSwitch'
    - 'FlowTemperature'
    - 'Flame'
    - 'PowerEnergyConsumptionHeatingCircuit'
    - 'PowerEnergyConsumptionHotWaterCircuit'
    - 'RoomThermostat'
    - 'HeatingPartLoad'

Checklist:

  • [*] The code change is tested and works locally.
  • [*] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [*] There is no commented out code in this PR.
  • [*] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [-] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • [-] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [-] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [-] Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 19, 2019
@sashao sashao referenced this pull request Sep 19, 2019
@sashao sashao force-pushed the sashao:dev branch from 573ea05 to 5f733df Sep 19, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Hi @sashao,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@sashao sashao changed the title Added support for more ebus "bai" sensors. Added support for more ebusd Vaillant "bai" sensors. Sep 19, 2019
@sashao sashao force-pushed the sashao:dev branch from 5f733df to 9ba731c Sep 19, 2019
@sashao sashao force-pushed the sashao:dev branch from 9ba731c to 1cb12d6 Sep 19, 2019
@MartinHjelmare MartinHjelmare changed the title Added support for more ebusd Vaillant "bai" sensors. Add more ebusd Vaillant "bai" sensors Sep 20, 2019
@home-assistant home-assistant deleted a comment from homeassistant Sep 20, 2019
Copy link
Member

left a comment

Some of these sensor types would benefit from setting the entity property device_class.

https://developers.home-assistant.io/docs/en/entity_sensor.html#available-device-classes

It's not required for this PR, as it would be a larger change.

homeassistant/components/ebusd/const.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 20, 2019
Fixed review item
@project-bot project-bot bot moved this from Review in progress to Needs review in Dev Sep 21, 2019
@home-assistant home-assistant deleted a comment from homeassistant Sep 21, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 21, 2019

Please run black code formatter from the project root.

black --fast homeassistant
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Sep 21, 2019
@sashao

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Can't figure out why CI fails on CheckFormat. Where I can find better error description?

@frenck

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

@sashao As pointed out by MartinHjelmare, we use Black to format our code. Just run it from the project root to apply the correct formatting:

black --fast homeassistant

sashao added 4 commits Sep 24, 2019
black --fast homeassistant
merge upstream
@sashao

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

Pylint is still failing. But looks like this is known issue since pull requests are getting merged with the same #26890

@sashao

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

Some of these sensor types would benefit from setting the entity property device_class.

https://developers.home-assistant.io/docs/en/entity_sensor.html#available-device-classes

It's not required for this PR, as it would be a larger change.

@MartinHjelmare I don't feel skilled enough to improve this. Could you please rereview this PR?

Dev automation moved this from Review in progress to Reviewer approved Sep 25, 2019
Copy link
Member

left a comment

This is good. We just need to make the build pass.

sashao added 4 commits Sep 25, 2019
Merge upstream dev branch with pylint fixes
Fix bed_activity history chart of the Xiaomi Aqara vibration sensor (…
merge dev
@MartinHjelmare MartinHjelmare merged commit 77b7e46 into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190926.47 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c194f4a...bba7b84
Details
codecov/project 94.18% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.