Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vivotek camera component #26754

Merged

Conversation

@HarlemSquirrel
Copy link
Contributor

commented Sep 20, 2019

Load model name to instance attribute

Description:

  • Load model name to instance attribute
  • Update libpyvivotek to 0.2.2
    • Retrieve camera model name anonymously
    • Raise a more helpful error for invalid creds

Related issue (if applicable): fixes #26607

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
Load model name to instance attribute
Copy link
Member

left a comment

Call add_entities with second argument True to make sure update is called during entity addition.

add_entities(entities, True)
Dev automation moved this from Needs review to Review in progress Sep 20, 2019
Ensure `update` is called when the entity is added.
https://pypi.org/project/libpyvivotek/0.2.2/
- Retrieve camera model name anonymously
- Raise a more helpful error for invalid creds
Copy link
Member

left a comment

Good!

Dev automation moved this from Review in progress to Reviewer approved Sep 22, 2019
@MartinHjelmare MartinHjelmare merged commit 2d906b1 into home-assistant:dev Sep 22, 2019
11 checks passed
11 checks passed
CI Build #20190922.63 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.07% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 22, 2019
@lock lock bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.