Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add transport data from maps.yandex.ru api" #26762

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@pvizeli
Copy link
Member

commented Sep 20, 2019

Reverts #26252

This reverts commit 9e2cd51.
@pvizeli

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2019

The library is not 100% conform and did not correct work with pip/packages.

Please fix the library and create a new PR.

@pvizeli pvizeli merged commit 9e44d1a into dev Sep 20, 2019
12 checks passed
12 checks passed
CI Build #20190920.17 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.04% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Sep 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-26252-dev branch Sep 20, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

Do we have more info on the problem?

@pvizeli

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2019

@MartinHjelmare that is not your issue. There was a problem with manifest and lizenz file. On the last two years, I saw only two libraries with this issue. I think that is handleable without CI check.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

Ok, thanks for the details. 👍

KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 20, 2019
* dev: (167 commits)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  Add Plex config flow support (home-assistant#26548)
  Bump pyobihai to fix issue with user account (home-assistant#26736)
  Bump TRADFRI (home-assistant#26731)
  Encode prometheus metric names per the prom spec (home-assistant#26639)
  Bump aiohttp to 3.6.1 (home-assistant#26739)
  ...
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 21, 2019
* dev: (92 commits)
  Bump pynws version to 0.8.1 (home-assistant#26770)
  Bump HAP-python to 2.6.0 for homekit (home-assistant#26783)
  [ci skip] Translation update
  Add integration scaffolding script (home-assistant#26777)
  Bump simplisafe-python to 5.0.1 (home-assistant#26775)
  Bump aiowwlln to 2.0.2 (home-assistant#26769)
  ZHA siren and warning device support (home-assistant#26046)
  Add transport data from maps.yandex.ru api (home-assistant#26766)
  Type hint additions (home-assistant#26765)
  Bump openwrt-luci-rpc to version 1.1.1 (home-assistant#26759)
  Revert "Add transport data from maps.yandex.ru api (home-assistant#26252)" (home-assistant#26762)
  [ci skip] Translation update
  Updated frontend to 20190919.0
  deCONZ improve gateway tests (home-assistant#26709)
  Add transport data from maps.yandex.ru api (home-assistant#26252)
  Update codeowners (home-assistant#26733)
  Bump influxdb to 5.2.3 (home-assistant#26743)
  Izone component (home-assistant#24550)
  Bump restrictedpython to 5.0 (home-assistant#26741)
  Bumped version to 0.99.1
  ...
@lock lock bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.