Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doods missing detector name kwarg #26784

Merged
merged 3 commits into from Sep 21, 2019

Conversation

@snowzach
Copy link
Contributor

commented Sep 21, 2019

Breaking Change:

No breaking changes

Description:

The new doods component is missing an option to select the detector being used. In its current form it will only use the default detector and ignores the detector config option.

No documentation or configuration changes are required. The documentation is already correct.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [ X] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
snowzach added 2 commits Sep 21, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
@MartinHjelmare MartinHjelmare changed the title Doods component - fix missing detector name kwarg Fix doods missing detector name kwarg Sep 21, 2019
@cgarwood cgarwood merged commit 9e79920 into home-assistant:dev Sep 21, 2019
11 checks passed
11 checks passed
CI Build #20190921.25 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8502f7c...6cdef52
Details
codecov/project 94.05% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 21, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.