Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-whois to 0.7.2 #26788

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@fabaff
Copy link
Member

commented Sep 21, 2019

Description:

Commit history: https://github.com/richardpenman/pywhois/commits/master

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: whois
    domain: home-assistant.io

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@frenck
frenck approved these changes Sep 21, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
@cgarwood cgarwood merged commit a9ff150 into dev Sep 21, 2019
12 checks passed
12 checks passed
CI Build #20190921.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ed21019...7b1aff1
Details
codecov/project 94.04% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-python-whois branch Sep 21, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.