Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for clarity to helper.entity.enabled() #26793

Merged
merged 4 commits into from Sep 24, 2019

Conversation

@frenck
Copy link
Member

commented Sep 21, 2019

Description:

self.registry_entry may still be None, so the current expression on the Entity.enabled() method, is actually incorrect. This PR prevents calling self.registry_entry.disabled on a NoneType.

Added comment for clarity to helper.entity.enabled() as suggested in the PR comments.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck frenck requested a review from home-assistant/core as a code owner Sep 21, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 21, 2019
@frenck

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2019

NVM this is actually incorrect... hold on...

Better, it now still returns true, when it is not an Entity from registry.

@frenck

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2019

This PR makes no sense at all. Closing.

@frenck frenck closed this Sep 21, 2019
Dev automation moved this from Needs review to Cancelled Sep 21, 2019
@frenck frenck deleted the frenck-2019-0190 branch Sep 21, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

If an entity is not part of the entity registry, it is not able to disable it, so it is always enabled.

@balloob

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

(that would be a helpful comment in the code)

@frenck frenck restored the frenck-2019-0190 branch Sep 24, 2019
@frenck

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

Well let's add that comment in that case

@frenck frenck reopened this Sep 24, 2019
Dev automation moved this from Cancelled to Needs review Sep 24, 2019
@frenck frenck changed the title Fixes entity enabled expression WIP: Fixes entity enabled expression Sep 24, 2019
@frenck frenck force-pushed the frenck-2019-0190 branch from 3d3bf74 to 1bcfab7 Sep 24, 2019
@frenck frenck changed the title WIP: Fixes entity enabled expression Add comment for clarity to helper.entity.enabled() Sep 24, 2019
@balloob balloob merged commit b52cfd3 into dev Sep 24, 2019
1 of 5 checks passed
1 of 5 checks passed
CI This check was skipped
Details
Release This check was skipped
Details
Translation - Backend This check was skipped
Details
home-assistant-wheels This check was skipped
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Needs review to Done Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0190 branch Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.