Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself as a pi_hole codeowner #26796

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@johnluetke
Copy link
Contributor

commented Sep 21, 2019

Description:

I significantly refactored the pi-hole integration, so per ADR-008, I'm adding myself as a code owner.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@johnluetke johnluetke requested a review from fabaff as a code owner Sep 21, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 21, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 21, 2019
@frenck
frenck approved these changes Sep 21, 2019
Copy link
Member

left a comment

Thanks, @johnluetke! 👍 ❤️

@johnluetke johnluetke force-pushed the johnluetke:patch-1 branch from aee166f to f67c6d5 Sep 21, 2019
@frenck frenck merged commit 88dceca into home-assistant:dev Sep 21, 2019
11 checks passed
11 checks passed
CI Build #20190921.51 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9d0cb89...f67c6d5
Details
codecov/project 94.05% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 21, 2019
@johnluetke johnluetke deleted the johnluetke:patch-1 branch Sep 21, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.