Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shodan to 1.17.0 #26797

merged 2 commits into from Sep 22, 2019


Copy link

commented Sep 21, 2019


Bumps shodan to 1.17.0

Related issue (if applicable): n/a

Pull request with documentation for (if applicable): n/a

Example entry for configuration.yaml (if applicable):

  - platform: shodan
    api_key: SHODAN_API_KEY
    query: 'home-assistant'


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck frenck requested a review from fabaff as a code owner Sep 21, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 21, 2019
@frenck frenck changed the title Bump shodan to 1.16.0 Bump shodan to 1.17.0 Sep 22, 2019
@Danielhiversen Danielhiversen merged commit 48369ad into dev Sep 22, 2019
11 checks passed
11 checks passed
CI Build #20190922.28 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9d0cb89...141a307
codecov/project 94.05% (target 90%)
Dev automation moved this from Needs review to Done Sep 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0193 branch Sep 22, 2019
@lock lock bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.