Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomfort and bump client to 0.3.5 #26802

Merged
merged 16 commits into from Sep 30, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Sep 21, 2019

Breaking Change:

Removed esoteric device state attributes that were causing pointless state changes:

  • "rf_message_rssi" signal strength (between gateway & boiler), changes almost every scan_interval
  • "nodenr" unknown, is static
  • "rfstatus_cntr" unknown, changes

This is not likely to be considered a breaking change by users.

Description:

  • add a unique_id for each entity based upon the heater's serial number
  • change water_heater icon to something more appropriate
  • fix a potential bug where climate/sensor/binary_sensors would have been updated unnecessarily
  • some HA'ing, and some de-linting
  • much less logging when debugging mode is on in configuration.yaml:
logger:
  logs:
    incomfortclient: debug

The newer client has:

  • improved fake_room code (used for testing)
  • much reduced DEBUG logging
  • added f-strings, improved type hints, de-linted & blackened
  • fault code should be None, not 0 for no fault
  • bugfix: serial_no now calculated correctly

See: zxdavb/incomfort-client@v0.3.1...v0.3.5

Related issue (if applicable): fixes #26760

**Pull request with documentation for [home-assistant.io](if applicable): home-assistant/home-assistant.io#10494

Example entry for configuration.yaml (if applicable): N/A: unchanged

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 21, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 21, 2019
@zxdavb zxdavb changed the title Bugfix incomfort and bump client to 0.0.0 Bugfix incomfort and Bump client to 0.3.x Sep 21, 2019
zxdavb added 2 commits Sep 21, 2019
@zxdavb zxdavb added breaking change and removed small-pr labels Sep 24, 2019
@zxdavb zxdavb marked this pull request as ready for review Sep 28, 2019
@zxdavb zxdavb changed the title Bugfix incomfort and Bump client to 0.3.x Bugfix incomfort and Bump client to 0.3.2 Sep 28, 2019
zxdavb added 4 commits Sep 28, 2019
@zxdavb zxdavb changed the title Bugfix incomfort and Bump client to 0.3.2 Bugfix incomfort and Bump client to 0.3.3 Sep 28, 2019
@zxdavb zxdavb requested a review from MartinHjelmare Sep 29, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 29, 2019
@MartinHjelmare MartinHjelmare changed the title Bugfix incomfort and Bump client to 0.3.3 Fix incomfort and bump client to 0.3.3 Sep 29, 2019
Copy link
Member

left a comment

Please mention all breaking changes in the PR description. We shouldn't assume users won't care about breaking changes.

homeassistant/components/incomfort/climate.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Reviewer approved Sep 29, 2019
Copy link
Member

left a comment

Great!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

Can be merged when build passes.

@zxdavb zxdavb changed the title Fix incomfort and bump client to 0.3.3 Fix incomfort and bump client to 0.3.4 Sep 29, 2019
@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

@MartinHjelmare Thanks: as always, I've learnt something new!

@zxdavb zxdavb changed the title Fix incomfort and bump client to 0.3.4 Fix incomfort and bump client to 0.3.5 Sep 29, 2019
@zxdavb zxdavb changed the title Fix incomfort and bump client to 0.3.5 Fix incomfort and Bump client to 0.3.5 Sep 30, 2019
@zxdavb zxdavb merged commit fa92d0e into home-assistant:dev Sep 30, 2019
11 checks passed
11 checks passed
CI Build #20190929.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 11c9bab...7d08b71
Details
codecov/project 94.3% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 30, 2019
@zxdavb zxdavb deleted the zxdavb:incomfort_bugfix branch Sep 30, 2019
@zxdavb zxdavb changed the title Fix incomfort and Bump client to 0.3.5 Fix incomfort and bump client to 0.3.5 Sep 30, 2019
@zxdavb zxdavb referenced this pull request Oct 1, 2019
2 of 2 tasks complete
@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.