Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pylutron to 0.2.5 #26815

Merged
merged 1 commit into from Sep 22, 2019

Conversation

@thecynic
Copy link
Contributor

commented Sep 22, 2019

Description:

New version is much more robust against disconnections, fixes a string formatting exception, and adds better logging when uncaught exceptions are thrown.

Related issue (if applicable): fixes #20348

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • [x ] The code change is tested and works locally.
  • [x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [x ] There is no commented out code in this PR.
  • [x ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • [x ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 22, 2019
@thecynic

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2019

@cdheiser @JonGilmore FYI

@thecynic thecynic force-pushed the thecynic:dev-bump-pylutron branch from 14c0def to f3c7daf Sep 22, 2019
@thecynic thecynic force-pushed the thecynic:dev-bump-pylutron branch from f3c7daf to 2d556d0 Sep 22, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 22, 2019
@MartinHjelmare MartinHjelmare merged commit 04cae08 into home-assistant:dev Sep 22, 2019
9 checks passed
9 checks passed
CI Build #20190922.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 22, 2019
@thecynic thecynic deleted the thecynic:dev-bump-pylutron branch Sep 23, 2019
@lock lock bot locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.