Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sytadin integration (ADR-0004) #26819

Merged
merged 3 commits into from Sep 23, 2019

Conversation

@frenck
Copy link
Member

commented Sep 22, 2019

Breaking Change:

The Sytadin integration was deprecated in Home Assistant 0.98.0 and has now been removed in 0.100.0.

Description:

This PR removes the deprecated Sytadin integration since it relies on web scraping to function.
As per ADR-0004 this is no longer allowed. The integration has been deprecated for 2 releases and is now marked for permanent removal.

This integration was deprecated in PR #25742.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10419

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to removed from .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
frenck added 2 commits Sep 22, 2019
@frenck frenck referenced this pull request Sep 22, 2019
2 of 2 tasks complete
@frenck frenck added breaking change and removed docs-missing labels Sep 22, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

@pvizeli pvizeli merged commit 5c7f869 into dev Sep 23, 2019
12 checks passed
12 checks passed
CI Build #20190922.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5624e3e...72ee78a
Details
codecov/project 94.05% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Sep 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0199 branch Sep 23, 2019
@lock lock bot locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.