Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint additions #26831

merged 4 commits into from Sep 29, 2019


Copy link

commented Sep 22, 2019


Bunch of type additions again. This time goal is towards making it possible to use follow_imports = error for mypy for improved checking and dmypy goodness. Not quite there yet though.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

This comment has been minimized.

Copy link

commented Sep 25, 2019

This needs a rebase after device automation refactor.

Dev automation moved this from Needs review to Reviewer approved Sep 25, 2019
scop and others added 3 commits Sep 21, 2019
Co-Authored-By: Franck Nijhof <>
Co-Authored-By: Franck Nijhof <>
@scop scop force-pushed the scop:typing branch from 7707efd to de8b079 Sep 29, 2019
@scop scop merged commit f259ff1 into home-assistant:dev Sep 29, 2019
11 checks passed
11 checks passed
CI Build #20190929.29 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 95.45% of diff hit (target 94.3%)
codecov/project 94.3% (target 90%)
Dev automation moved this from Reviewer approved to Done Sep 29, 2019
@scop scop deleted the scop:typing branch Sep 29, 2019
@lock lock bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.