Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call direction sensor for Obihai #26867

Merged

Conversation

@dshokouhi
Copy link
Contributor

commented Sep 23, 2019

Breaking Change:

Description:

Add a call direction sensor for Obihai. States are No Active Calls Inbound Call or Outbound Call

Related issue (if applicable): fixes #N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: obihai
    host: 192.168.1.x

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
Dev automation moved this from Needs review to Review in progress Sep 24, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 24, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Not sure why pylint is failing.

@dshokouhi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

@MartinHjelmare yea its failing for other PR's as well for the same or similar reason.

dshokouhi added 4 commits Sep 23, 2019
@dshokouhi dshokouhi force-pushed the dshokouhi:add_call_direction_sensor_obihai branch from cb22894 to 6c80f18 Sep 25, 2019
@dshokouhi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@MartinHjelmare I have force pushed my branch after rebasing it and the pylint error is now resolved :)

@MartinHjelmare MartinHjelmare merged commit 36f604f into home-assistant:dev Sep 25, 2019
11 checks passed
11 checks passed
CI Build #20190925.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.14% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 25, 2019
@dshokouhi dshokouhi deleted the dshokouhi:add_call_direction_sensor_obihai branch Sep 25, 2019
@dshokouhi dshokouhi referenced this pull request Sep 25, 2019
7 of 7 tasks complete
@lock lock bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.