Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plex config options support #26870

Merged
merged 5 commits into from Sep 26, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Sep 24, 2019

Description:

Add config options support for Plex media_player platform options (use_episode_art and show_all_controls).

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10450

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@jjlawren jjlawren referenced this pull request Sep 24, 2019
2 of 2 tasks complete
@@ -96,6 +96,14 @@ def _setup_plex(hass, config):
"""Set up Plex from a config entry."""
server_config = entry.data[PLEX_SERVER_CONFIG]

if MP_DOMAIN not in entry.options:

This comment has been minimized.

Copy link
@Kane610

Kane610 Sep 24, 2019

Member

Shouldn't you add tests for this as well?

This comment has been minimized.

Copy link
@jjlawren

jjlawren Sep 24, 2019

Author Contributor

I'd eventually like to add tests for files outside of config_flow.py, but I'm not there quite yet.

@jjlawren jjlawren force-pushed the jjlawren:plex_config_options branch from 5345563 to ac58cb3 Sep 25, 2019
jjlawren added 4 commits Sep 24, 2019
@jjlawren jjlawren force-pushed the jjlawren:plex_config_options branch from 0b411ac to a2cffd6 Sep 25, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 25, 2019
Copy link
Member

left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit 9b204ad into home-assistant:dev Sep 26, 2019
11 checks passed
11 checks passed
CI Build #20190925.59 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.16%)
Details
codecov/project 94.17% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 26, 2019
@jjlawren jjlawren deleted the jjlawren:plex_config_options branch Sep 26, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 26, 2019
* dev: (87 commits)
  Add ecobee services to create and delete vacations (home-assistant#26923)
  Centralize rainbird config and add binary sensor platform (home-assistant#26393)
  Add config flow to transmission (home-assistant#26434)
  Add Plex config options support (home-assistant#26870)
  Bump pyobihai, add unique ID and availability (home-assistant#26922)
  Add mysensors codeowner (home-assistant#26917)
  [ci skip] Translation update
  Add MySensors ACK (home-assistant#26894)
  Remove lamps and groups from ha when removed from Hue (home-assistant#26881)
  Add config flow to ecobee (home-assistant#26634)
  deCONZ - Increase bridge discovery robustness in config flow (home-assistant#26911)
  Add call direction sensor for Obihai (home-assistant#26867)
  Bumped version to 0.99.3
  HM-CC-TC was not recognized (home-assistant#26623)
  Add google_assistant alarm_control_panel (home-assistant#26249)
  deCONZ - Improve ssdp discovery by storing uuid in config entry (home-assistant#26882)
  Fix missing whitespace around arithmetic operator (home-assistant#26908)
  Fix bed_activity history chart of the Xiaomi Aqara vibration sensor (home-assistant#26875)
  Add voltage attribute to Xiaomi Aqara devices (home-assistant#26876)
  Bump ndms2-client to 0.0.9 (home-assistant#26899)
  ...
@lock lock bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.