Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bed_activity history chart of the Xiaomi Aqara vibration sensor #26875

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@zhumuht
Copy link
Contributor

commented Sep 24, 2019

Description:

fix xiaom activity sensor show in history chart.

changed before like this, not show x-y chart:
image

changed after:
image

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@syssi
syssi approved these changes Sep 24, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 24, 2019
@MartinHjelmare MartinHjelmare changed the title fix xiaomi activity sensor history chart Fix xiaomi activity sensor history chart Sep 24, 2019
@@ -19,6 +19,7 @@
"illumination": ["lm", None, DEVICE_CLASS_ILLUMINANCE],
"lux": ["lx", None, DEVICE_CLASS_ILLUMINANCE],
"pressure": ["hPa", None, DEVICE_CLASS_PRESSURE],
"bed_activity": ["μm", None, DEVICE_CLASS_PRESSURE],

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Sep 24, 2019

Member

Is this sensor really measuring pressure?

This comment has been minimized.

Copy link
@zhumuht

zhumuht Sep 25, 2019

Author Contributor

Is this sensor really measuring pressure?

this is vibration sensor.
https://www.aqara.com/en/vibration_sensor.html

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Sep 25, 2019

Member

Then we should not use DEVICE_CLASS_PRESSURE. We can replace that with None.

This comment has been minimized.

Copy link
@zhumuht

zhumuht Sep 25, 2019

Author Contributor

Then we should not use DEVICE_CLASS_PRESSURE. We can replace that with None.

done.

@syssi syssi changed the title Fix xiaomi activity sensor history chart Fix bed_activity history chart of the Xiaomi Aqara vibration sensor Sep 25, 2019
@syssi syssi merged commit 626b61b into home-assistant:dev Sep 25, 2019
11 checks passed
11 checks passed
CI Build #20190925.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 930dadb...6e8a76f
Details
codecov/project 94.16% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 25, 2019
@lock lock bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.