Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lamps and groups from ha when removed from Hue #26881

merged 5 commits into from Sep 25, 2019


Copy link

commented Sep 24, 2019


This PR removes lamps and groups that are removed in Hue.

  • add tests.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@bramkragten bramkragten requested review from balloob and home-assistant/core as code owners Sep 24, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 24, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 25, 2019
Copy link

left a comment

ok with tests !

dev_registry.async_update_device(, remove_config_entry_id=config_entry.entry_id
if item_id in api:

This comment has been minimized.

Copy link

balloob Sep 25, 2019


Is this code that needs to be generalized for sensors (in a future PR) ?

This comment has been minimized.

Copy link

bramkragten Sep 25, 2019

Author Member

Yes, probably


This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2019

Why is lint failing on xiaomi_aqara? Have not touched that code. And black fails? Did run black...


This comment has been minimized.

Copy link

commented Sep 25, 2019


bramkragten added 5 commits Sep 23, 2019
@bramkragten bramkragten force-pushed the hue-improv branch from 4cb2adb to 5e773ac Sep 25, 2019
@balloob balloob merged commit b75639d into dev Sep 25, 2019
11 checks passed
11 checks passed
CI Build #20190925.72 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.16%)
codecov/project 94.16% (target 90%)
Dev automation moved this from Reviewer approved to Done Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the hue-improv branch Sep 25, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 26, 2019
* dev: (87 commits)
  Add ecobee services to create and delete vacations (home-assistant#26923)
  Centralize rainbird config and add binary sensor platform (home-assistant#26393)
  Add config flow to transmission (home-assistant#26434)
  Add Plex config options support (home-assistant#26870)
  Bump pyobihai, add unique ID and availability (home-assistant#26922)
  Add mysensors codeowner (home-assistant#26917)
  [ci skip] Translation update
  Add MySensors ACK (home-assistant#26894)
  Remove lamps and groups from ha when removed from Hue (home-assistant#26881)
  Add config flow to ecobee (home-assistant#26634)
  deCONZ - Increase bridge discovery robustness in config flow (home-assistant#26911)
  Add call direction sensor for Obihai (home-assistant#26867)
  Bumped version to 0.99.3
  HM-CC-TC was not recognized (home-assistant#26623)
  Add google_assistant alarm_control_panel (home-assistant#26249)
  deCONZ - Improve ssdp discovery by storing uuid in config entry (home-assistant#26882)
  Fix missing whitespace around arithmetic operator (home-assistant#26908)
  Fix bed_activity history chart of the Xiaomi Aqara vibration sensor (home-assistant#26875)
  Add voltage attribute to Xiaomi Aqara devices (home-assistant#26876)
  Bump ndms2-client to 0.0.9 (home-assistant#26899)
@lock lock bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.