Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - Improve discovery by storing uuid in config entry #26882

Conversation

@Kane610
Copy link
Member

commented Sep 24, 2019

Breaking Change:

Description:

Allow discovery to update any deconz entry, loaded or not

Related issue (if applicable): fixes #25863

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 24, 2019
@Kane610 Kane610 self-assigned this Sep 24, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-improve-discovery-updating-config-entry branch from aa9fd34 to d1ab122 Sep 24, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 25, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-improve-discovery-updating-config-entry branch from c6f2d47 to 9e3dcd7 Sep 25, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-improve-discovery-updating-config-entry branch from c3134c5 to 01cd805 Sep 25, 2019
Kane610 added 3 commits Sep 24, 2019
…date any deconz entry, loaded or not
@Kane610 Kane610 force-pushed the Kane610:deconz-improve-discovery-updating-config-entry branch from 01cd805 to 082f489 Sep 25, 2019
@Kane610 Kane610 merged commit 4582b6e into home-assistant:dev Sep 25, 2019
11 checks passed
11 checks passed
CI Build #20190925.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.16%)
Details
codecov/project 94.16% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 25, 2019
@Kane610 Kane610 deleted the Kane610:deconz-improve-discovery-updating-config-entry branch Sep 25, 2019
@lock lock bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.