Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary else/elif blocks #26884

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@frenck
Copy link
Member

commented Sep 24, 2019

Description:

Removes unnecessary else and elif blocks after break and continue statements.

In preparation for pylint>=2.4.0, which added new checks, no-else-break and no-else-continue.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck frenck requested review from home-assistant/core as code owners Sep 24, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 24, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 24, 2019
@balloob balloob merged commit b1118cb into dev Sep 24, 2019
10 of 12 checks passed
10 of 12 checks passed
CI Build #20190924.70 failed
Details
CI (FullCheck Pylint) FullCheck Pylint failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.14%)
Details
codecov/project 94.13% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0213 branch Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.