Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary print_function future import #26888

merged 1 commit into from Sep 25, 2019


Copy link

commented Sep 24, 2019


Removes unnecessary print_function future import.
This future was to get the print() function into Python 2, which we do not support.
On Python 3, this has no effect at all.

Related issue (if applicable): n/a

Pull request with documentation for (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck frenck requested a review from home-assistant/core as a code owner Sep 24, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 24, 2019
@@ -1,6 +1,4 @@
"""Start Home Assistant."""
from __future__ import print_function

This comment has been minimized.

Copy link

balloob Sep 25, 2019


So the reason for this actually used to be that under Python 2, if you were able to install Home Assistant, we would actually tell you that your Python version was not supported. But I guess Python 2 is dead, so it's fine.

Dev automation moved this from Needs review to Reviewer approved Sep 25, 2019
@balloob balloob merged commit 1f03508 into dev Sep 25, 2019
10 of 12 checks passed
10 of 12 checks passed
CI Build #20190924.79 failed
CI (FullCheck Pylint) FullCheck Pylint failed
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b1118cb...fa53c3b
codecov/project 94.14% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0215 branch Sep 25, 2019
@lock lock bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.