Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyowlet to 1.0.3 #26892

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@jaburges
Copy link
Contributor

commented Sep 24, 2019

API URLs have been updated which prevented 1.0.2 from authenticating per this thread:
https://community.home-assistant.io/t/owlet-setup/130751

https://user-field-1a2039d9.aylanetworks.com/users/sign_in
https://ads-field-1a2039d9.aylanetworks.com/apiv1

have been updated in PyOwlet.py 1.0.3

Breaking Change:

Description:

Owlet component fails to authenticate

Related issue (if applicable): fixes #25962

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
API URLs
API URLs have been updated which prevented 1.0.2 from authenticating per this thread:
https://community.home-assistant.io/t/owlet-setup/130751
```
https://user-field-1a2039d9.aylanetworks.com/users/sign_in
https://ads-field-1a2039d9.aylanetworks.com/apiv1
```
have been updated in PyOwlet.py 1.0.3
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Hi @jaburges,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Sep 24, 2019
@homeassistant homeassistant added cla-signed and removed cla-needed labels Sep 24, 2019
@frenck

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

Please run python3 -m script.gen_requirements_all to update all requirement files.

jaburges added a commit to jaburges/home-assistant that referenced this pull request Sep 24, 2019
To match change in Owlet integration: home-assistant#26892
@jaburges jaburges referenced this pull request Sep 24, 2019
6 of 9 tasks complete
@jaburges jaburges changed the title API URLs pyowlet version bumped to 1.0.3 with updated API URLs Sep 25, 2019
@MartinHjelmare MartinHjelmare changed the title pyowlet version bumped to 1.0.3 with updated API URLs Bump pyowlet to 1.0.3 Sep 26, 2019
@jaburges

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

@frenck I updated the all_requirements.txt to 1.0.3 - not exactly sure how to complete this process? would you mind providing some guidance

I 'think' i figured it out. Apologies for the false alarm

@frenck
frenck approved these changes Sep 27, 2019
Copy link
Member

left a comment

Looks good now @jaburges! 👍

Dev automation moved this from Needs review to Reviewer approved Sep 27, 2019
@frenck frenck merged commit 454d479 into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190927.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6fdff9f...7c0c44e
Details
codecov/project 94.18% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.