Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoNet NZ Volcanic Alert Level sensor #26901

Merged
merged 26 commits into from Nov 19, 2019

Conversation

@exxamalte
Copy link
Contributor

exxamalte commented Sep 25, 2019

Breaking Change:

Description:

This is a new integration that fetches information about volcanos in New Zealand from a feed provided by GeoNet NZ.
A sensor is created for each volcano in the feed (and within the defined radius). The sensor state is the current volcanic alert level which is a value from 0-5. Each sensor has additional attributes such as the volcano's coordinates, distance to home, volcanic activity, hazards and the last update date.
The preferred way to set up this integration is through the UI where you can define the radius around the HA instance to include volcanos from.

I decided to create sensors instead of geolocation entities for this feed integration because the location of the volcanos does not change, and the most important information of each entity is not the distance, but the volcanic alert level.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10464

Example entry for configuration.yaml (if applicable):

geonetnz_volcano:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@exxamalte

This comment has been minimized.

Copy link
Contributor Author

exxamalte commented Sep 26, 2019

Doco added

@frenck frenck removed the docs-missing label Sep 27, 2019
@exxamalte exxamalte force-pushed the exxamalte:geonetnz_volcano branch from 0c4b6f8 to 3635da1 Oct 14, 2019
@exxamalte

This comment has been minimized.

Copy link
Contributor Author

exxamalte commented Oct 14, 2019

Just rebased to 0.101.0.dev0

@exxamalte exxamalte force-pushed the exxamalte:geonetnz_volcano branch from 3635da1 to 521ac3b Oct 31, 2019
@exxamalte

This comment has been minimized.

Copy link
Contributor Author

exxamalte commented Oct 31, 2019

Just rebased to 0.102.0.dev0 to resolve merge conflict

@exxamalte exxamalte force-pushed the exxamalte:geonetnz_volcano branch from bc4e0ba to 1de9bd1 Nov 7, 2019
@exxamalte

This comment has been minimized.

Copy link
Contributor Author

exxamalte commented Nov 7, 2019

Just rebased again, and bumped the version of the integration library to make it compatible with Python 3.8.

Dev automation moved this from Needs review to Review in progress Nov 7, 2019
exxamalte added 8 commits Nov 8, 2019


@pytest.fixture
def config_entry():

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Nov 10, 2019

Member

If this fixture is the same as the one in the config flow tests module we can make a common fixture in a conftest.py module in the geonetz_volcano test package.

This comment has been minimized.

Copy link
@exxamalte

exxamalte Nov 10, 2019

Author Contributor

Thanks for the hint, I wasn't aware of the conftest.py magic.

Dev automation moved this from Review in progress to Reviewer approved Nov 10, 2019
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 4e9e9ef into home-assistant:dev Nov 19, 2019
11 checks passed
11 checks passed
CI Build #20191110.8 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 98.42% of diff hit (target 94.39%)
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.