Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saj component #26902

Merged
merged 9 commits into from Oct 1, 2019

Conversation

@fredericvl
Copy link
Contributor

commented Sep 25, 2019

Description:

The saj sensor will poll a SAJ solar inverter and present the values as sensors in Home Assistant.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10455

Example entry for configuration.yaml:

sensor:
  - platform: saj
    host: IP_ADDRESS_OF_DEVICE

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Sep 25, 2019
@fredericvl fredericvl referenced this pull request Sep 25, 2019
2 of 2 tasks complete
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Sep 27, 2019
@fredericvl fredericvl requested a review from MartinHjelmare Sep 27, 2019
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
script/gen_requirements_all.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
fredericvl added 2 commits Sep 30, 2019
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
@fredericvl fredericvl force-pushed the fredericvl:saj branch from 9df87b6 to c118d12 Sep 30, 2019
fredericvl added 2 commits Sep 30, 2019
Copy link
Member

left a comment

Looks good! Just a small comment left.

homeassistant/components/saj/sensor.py Outdated Show resolved Hide resolved
@fredericvl

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

@MartinHjelmare is there a way to rerun the CI tests without pushing a new commit?
It looks like the Python36 test was failed due to a "connection reset by peer" error while downloading a PyPi package

Copy link
Member

left a comment

Great!

Dev automation moved this from Review in progress to Reviewer approved Sep 30, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

I don't think I have that power unfortunately.

If you're comfortable with git you can rebase the last commit and force push to trigger another build or simply close and open the PR again.

@fredericvl fredericvl force-pushed the fredericvl:saj branch from 4cbc1b0 to bf77b21 Sep 30, 2019
@MartinHjelmare MartinHjelmare merged commit 2e3bc59 into home-assistant:dev Oct 1, 2019
11 checks passed
11 checks passed
CI Build #20190930.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8c01ed8...bf77b21
Details
codecov/project 94.3% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Oct 1, 2019
@lock lock bot locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.