Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device action support for ZHA #26903

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@dmulcahey
Copy link
Contributor

commented Sep 25, 2019

Description:

This PR adds device action support for ZHA devices.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@probot-home-assistant

This comment has been minimized.

Copy link

commented Sep 25, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 26, 2019
@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha_device_actions branch from 361c991 to 2e2edee Sep 26, 2019
@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha_device_actions branch from 2e2edee to 5dceef9 Sep 27, 2019
dmulcahey added 2 commits Sep 27, 2019
@dmulcahey dmulcahey changed the title WIP - Add ZHA device action support Add device action support for ZHA Sep 27, 2019
@dmulcahey dmulcahey marked this pull request as ready for review Sep 27, 2019
@dmulcahey dmulcahey requested a review from Adminiuga as a code owner Sep 27, 2019
@dmulcahey dmulcahey requested a review from balloob Sep 27, 2019
Dev automation moved this from Incoming to Review in progress Sep 27, 2019
Copy link
Contributor

left a comment

Just need to sort imports in zha/core/helpers.py and can be merged.

Copy link
Contributor

left a comment

Looks good. Can be merged when build passes.

Dev automation moved this from Review in progress to Reviewer approved Sep 27, 2019
from .core.const import CHANNEL_IAS_WD
from .core.helpers import async_get_zha_device

ACTION_SQUAWK = "squawk"

This comment has been minimized.

Copy link
@balloob

balloob Sep 27, 2019

Member

Glad to see squawk support land 🐦

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Sep 27, 2019

Author Contributor

😂

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Sep 27, 2019

Author Contributor

That’s the name in ZCL 🤷‍♂

@balloob balloob merged commit b1a9fa4 into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190927.37 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.18%)
Details
codecov/project 94.19% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.