Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - Support Symfonisk sound controller with device triggers #26913

Conversation

@Kane610
Copy link
Member

commented Sep 25, 2019

Description:

Awaiting finalization of deCONZ support from this thread: dresden-elektronik/deconz-rest-plugin#1898

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Kane610 Kane610 self-assigned this Sep 25, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 25, 2019
@Kane610 Kane610 changed the title deCONZ - support Symfonisk sound controller with device triggers deCONZ - Support Symfonisk sound controller with device triggers Sep 25, 2019
@Kane610 Kane610 force-pushed the Kane610:deconz-device_trigger-ikea_symfonisk_sound_controller branch from cef3714 to 5b67d49 Sep 25, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Sep 26, 2019
@Kane610 Kane610 marked this pull request as ready for review Sep 27, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Sep 28, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
@balloob
balloob approved these changes Oct 2, 2019
@Kane610 Kane610 merged commit d8c6b28 into home-assistant:dev Oct 2, 2019
10 checks passed
10 checks passed
CI Build #20190927.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@Kane610 Kane610 deleted the Kane610:deconz-device_trigger-ikea_symfonisk_sound_controller branch Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.