Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyobihai, add unique ID and availability #26922

merged 3 commits into from Sep 26, 2019


Copy link

commented Sep 25, 2019

Breaking Change:


Bump pyobihai so credentials are stored and not used in each method per recommendation #26867 (comment). Add unique ID as device serial for entity registry. Add availability if there is a state.

Related issue (if applicable): fixes #

Pull request with documentation for (if applicable): home-assistant/

Example entry for configuration.yaml (if applicable):

  - platform: obihai
    host: 192.168.1.x


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Sep 26, 2019
Dev automation moved this from Review in progress to Reviewer approved Sep 26, 2019
Copy link

left a comment


@pvizeli pvizeli merged commit 62cea2b into home-assistant:dev Sep 26, 2019
11 checks passed
11 checks passed
CI Build #20190926.7 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d1b4bd2...803dec2
codecov/project 94.17% (target 90%)
Dev automation moved this from Reviewer approved to Done Sep 26, 2019
@dshokouhi dshokouhi deleted the dshokouhi:bump_pyobibihai branch Sep 26, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Sep 26, 2019
* dev: (87 commits)
  Add ecobee services to create and delete vacations (home-assistant#26923)
  Centralize rainbird config and add binary sensor platform (home-assistant#26393)
  Add config flow to transmission (home-assistant#26434)
  Add Plex config options support (home-assistant#26870)
  Bump pyobihai, add unique ID and availability (home-assistant#26922)
  Add mysensors codeowner (home-assistant#26917)
  [ci skip] Translation update
  Add MySensors ACK (home-assistant#26894)
  Remove lamps and groups from ha when removed from Hue (home-assistant#26881)
  Add config flow to ecobee (home-assistant#26634)
  deCONZ - Increase bridge discovery robustness in config flow (home-assistant#26911)
  Add call direction sensor for Obihai (home-assistant#26867)
  Bumped version to 0.99.3
  HM-CC-TC was not recognized (home-assistant#26623)
  Add google_assistant alarm_control_panel (home-assistant#26249)
  deCONZ - Improve ssdp discovery by storing uuid in config entry (home-assistant#26882)
  Fix missing whitespace around arithmetic operator (home-assistant#26908)
  Fix bed_activity history chart of the Xiaomi Aqara vibration sensor (home-assistant#26875)
  Add voltage attribute to Xiaomi Aqara devices (home-assistant#26876)
  Bump ndms2-client to 0.0.9 (home-assistant#26899)
@lock lock bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.