Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Nest HVAC mode when disabling Eco mode #26934

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@joe248
Copy link
Contributor

commented Sep 26, 2019

Description:

Also fixed a bug where preset_mode was returning None instead of PRESET_NONE

Related issue (if applicable): fixes #26851

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@joe248 joe248 requested a review from awarecan as a code owner Sep 26, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 26, 2019
Copy link
Member

left a comment

Looks good!

@awarecan ?

Dev automation moved this from Needs review to Reviewer approved Sep 26, 2019
@awarecan

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

@balloob has better knowledge about this change.

@pvizeli pvizeli merged commit b88772e into home-assistant:dev Sep 27, 2019
12 checks passed
12 checks passed
CI Build #20190926.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3efdf29...d8fdbd9
Details
codecov/project 94.18% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.