Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xbox live custom update interval #26939

Merged
merged 3 commits into from Sep 27, 2019

Conversation

@MartinHjelmare
Copy link
Member

commented Sep 26, 2019

Breaking Change:

N/A

Description:

  • Set a default update interval that is within the free limit. Consider number of users per api key when setting interval.
  • Add myself as codeowner.

Related issue (if applicable):
fixes #16105
closes #26930

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: xbox_live
    api_key: API_KEY
    xuid:
      - 1234567891234567
      - 1234567891234568

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
* Set a default update interval that is within the free limit. Consider
  number of users per api key when setting interval.
@MartinHjelmare

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

CC @frenck

@frenck
frenck approved these changes Sep 26, 2019
@frenck

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Nice work mister! 🎉 🏅

@frenck frenck referenced this pull request Sep 26, 2019
4 of 9 tasks complete
@MartinHjelmare MartinHjelmare added this to Reviewer approved in Dev Sep 27, 2019
@MartinHjelmare MartinHjelmare changed the title Add xbox live custom update Add xbox live custom update interval Sep 27, 2019
@MartinHjelmare MartinHjelmare merged commit 9f6fade into dev Sep 27, 2019
12 checks passed
12 checks passed
CI Build #20190926.36 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3efdf29...8eb14c5
Details
codecov/project 94.18% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-xbox_live-custom-update branch Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.