Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Z-Wave battery level #26943

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@oandrew
Copy link
Contributor

commented Sep 27, 2019

Description:

Add support for Z-Wave battery level sensor

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@oandrew oandrew requested a review from home-assistant/z-wave as a code owner Sep 27, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

Hi @oandrew,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@oandrew oandrew force-pushed the oandrew:zwave-battery-sensor branch from 511ab6a to 5bb5ae1 Sep 27, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Sep 27, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 27, 2019
@balloob balloob merged commit eeffd09 into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190927.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.18%)
Details
codecov/project 94.18% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.