Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecobee integration #26951

merged 2 commits into from Sep 27, 2019


Copy link

commented Sep 27, 2019


Fixes the ecobee config flow crashing when there is no entry in configuration.yaml. Without an entry in configuration.yaml, async_step_user raises a KeyError as DATA_ECOBEE_CONFIG does not exist in (as async_setup is never called), so a check is needed in async_step_user.

Related issue (if applicable): fixes #26950

Pull request with documentation for (if applicable): N/A


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Dev automation moved this from Needs review to Review in progress Sep 27, 2019
Co-Authored-By: Martin Hjelmare <>
Copy link

left a comment


Dev automation moved this from Review in progress to Reviewer approved Sep 27, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Good to go!

@MartinHjelmare MartinHjelmare merged commit 1de0020 into home-assistant:dev Sep 27, 2019
11 checks passed
11 checks passed
CI Build #20190927.26 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.18%)
codecov/project 94.18% (target 90%)
Dev automation moved this from Reviewer approved to Done Sep 27, 2019
@lock lock bot locked and limited conversation to collaborators Sep 28, 2019
@marthoc marthoc deleted the marthoc:fix-ecobee-integration branch Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.